Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes related to MPL drawer #1444

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Fixes related to MPL drawer #1444

merged 3 commits into from
Sep 11, 2024

Conversation

MatteoRobbiati
Copy link
Contributor

@MatteoRobbiati MatteoRobbiati commented Sep 11, 2024

Thanks @sergiomtzlosa for the fixes already done in #1438. We can keep that PR to solve the coverage problems and use this one to fix asap the errors.

Checklist:

@sergiomtzlosa
Copy link
Contributor

great @MatteoRobbiati just let me know to get hands on

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 97.10%. Comparing base (7864590) to head (bf626f5).
Report is 118 commits behind head on master.

Files with missing lines Patch % Lines
src/qibo/ui/mpldrawer.py 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1444      +/-   ##
==========================================
- Coverage   99.94%   97.10%   -2.84%     
==========================================
  Files          78       81       +3     
  Lines       11324    11653     +329     
==========================================
- Hits        11318    11316       -2     
- Misses          6      337     +331     
Flag Coverage Δ
unittests 97.10% <0.00%> (-2.84%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renatomello renatomello added this to the Qibo 0.2.12 milestone Sep 11, 2024
@renatomello renatomello added the bug Something isn't working label Sep 11, 2024
@renatomello renatomello changed the title Couple of fixes related to MPL drawer Fixes related to MPL drawer Sep 11, 2024
@renatomello
Copy link
Contributor

@MatteoRobbiati I can't merge it since coverage is not passing. Idk if you have the right level of authorization for that or if it's just @scarrazza

@scarrazza
Copy link
Member

Coverage is failing, correct?

@renatomello
Copy link
Contributor

Coverage is failing, correct?

If I understood correctly, coverage fix is being implemented in #1438

@sergiomtzlosa
Copy link
Contributor

Coverage is failing, correct?

If I understood correctly, coverage fix is being implemented in #1438

Yes, you are right

@MatteoRobbiati
Copy link
Contributor Author

Yes, correct. With this we fix errors and with the other one we can fix coverage. If you prefer, we can fix everything there, but that will take a bit more time.

@renatomello
Copy link
Contributor

Yes, correct. With this we fix errors and with the other one we can fix coverage. If you prefer, we can fix everything there, but that will take a bit more time.

I'd prefer if this is merged as is, so other PRs can move forward while #1438 fixes the coverage.

@scarrazza
Copy link
Member

I agree, thanks.

@scarrazza scarrazza merged commit 218f298 into master Sep 11, 2024
27 of 29 checks passed
@renatomello renatomello deleted the fix_mpl branch September 11, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc tests failing because of %matplotlib inline Variable not defined in mpldrawer
4 participants