-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes related to MPL drawer #1444
Conversation
great @MatteoRobbiati just let me know to get hands on |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1444 +/- ##
==========================================
- Coverage 99.94% 97.10% -2.84%
==========================================
Files 78 81 +3
Lines 11324 11653 +329
==========================================
- Hits 11318 11316 -2
- Misses 6 337 +331
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Renato Mello <[email protected]>
for more information, see https://pre-commit.ci
@MatteoRobbiati I can't merge it since coverage is not passing. Idk if you have the right level of authorization for that or if it's just @scarrazza |
Coverage is failing, correct? |
If I understood correctly, coverage fix is being implemented in #1438 |
Yes, you are right |
Yes, correct. With this we fix errors and with the other one we can fix coverage. If you prefer, we can fix everything there, but that will take a bit more time. |
I'd prefer if this is merged as is, so other PRs can move forward while #1438 fixes the coverage. |
I agree, thanks. |
Thanks @sergiomtzlosa for the fixes already done in #1438. We can keep that PR to solve the coverage problems and use this one to fix asap the errors.
Checklist: