-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjusting Clifford condition in gates.GPI2
#1399
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1399 +/- ##
=======================================
Coverage 99.99% 99.99%
=======================================
Files 78 78
Lines 11192 11195 +3
=======================================
+ Hits 11191 11194 +3
Misses 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before merging: did anyone check if the GPI2
is actually a Clifford in those parameters?
Yes, it is because |
I don't see it from the |
Sorry, you are right. This happens for the paulis = [gates.X(0).matrix(), gates.Y(0).matrix(), gates.Z(0).matrix()]
for p in paulis:
for t in [0, np.pi/2, np.pi, 3*np.pi/2, 2*np.pi]:
gate = gates.GPI2(0, t).matrix()
gate1 = gate@p@gate.transpose().conj()
print(gate1) |
That's an error: GPI2 is always a rotation by E.g., cf. https://ionq.com/docs/getting-started-with-native-gates#gpi2 |
In the previous code I was printing |
@AlejandroSopena of course, my comment was referred not to the one directly above, but to the previous one, i.e. #1399 (comment) |
gates.GPI2
Checklist: