-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move some notebooks to tutorials
repository
#1349
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1349 +/- ##
=======================================
Coverage 99.84% 99.84%
=======================================
Files 74 74
Lines 10806 10806
=======================================
Hits 10789 10789
Misses 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MatteoRobbiati I would leave it to @andrea-pasquale to decide - we were aiming to document the module using notebooks.
We could move them for now and then later pull them in but @andrea-pasquale moving them will not break the current docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MatteoRobbiati, also the documentation needs to be updated propertly by removing the links to those notebooks.
I think the tutorials repository could be a nice place where to delve deeper into details of topics (e.g. in the case of the well documented DBI module) in form of notebooks.
I just opened a PR there: https://github.com/qiboteam/tutorials/pulls.
If someone else would prefer to take care of this feel, free to do it. Otherwise we can proceed like I suggested.
I would suggest to leave here at least the intro notebook and the readme file for completeness.
Checklist: