Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting Qibojit and Qibotn dependencies #1310

Merged
merged 5 commits into from
May 8, 2024
Merged

Conversation

BrunoLiegiBastonLiegi
Copy link
Contributor

@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi commented Apr 29, 2024

Small PR to restore the dependency to qibojit/main and qibotn/main.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.81%. Comparing base (9538523) to head (5697bdf).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1310   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files          72       72           
  Lines       10517    10517           
=======================================
  Hits        10498    10498           
  Misses         19       19           
Flag Coverage Δ
unittests 99.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi changed the title Reverting Qibojit dependency Reverting Qibojit and Qibotn dependencies Apr 30, 2024
@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi marked this pull request as ready for review April 30, 2024 13:18
Copy link
Contributor

@MatteoRobbiati MatteoRobbiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@MatteoRobbiati MatteoRobbiati added this pull request to the merge queue May 8, 2024
Merged via the queue into master with commit c132711 May 8, 2024
27 checks passed
@scarrazza scarrazza deleted the post_py3.12 branch June 25, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants