Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor seed generation in quantum_info.random_ensembles #1171

Merged
merged 14 commits into from
Feb 3, 2024
Merged

Refactor seed generation in quantum_info.random_ensembles #1171

merged 14 commits into from
Feb 3, 2024

Conversation

renatomello
Copy link
Contributor

@renatomello renatomello commented Jan 28, 2024 •
edited
Loading

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added enhancement New feature or request quantum_info module PRs and issues related to the quantum information module labels Jan 28, 2024
@renatomello renatomello added this to the Qibo 0.2.5 milestone Jan 28, 2024
@renatomello renatomello self-assigned this Jan 28, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0413922) 100.00% compared to head (93fa069) 100.00%.
Report is 2 commits behind head on master.

❗ Current head 93fa069 differs from pull request most recent head 4e8b201. Consider uploading reports for the commit 4e8b201 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##            master     #1171    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           69        68     -1     
  Lines        10084      9901   -183     
==========================================
- Hits         10084      9901   -183
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renatomello renatomello mentioned this pull request Jan 28, 2024
Merged
4 tasks
@renatomello @BrunoLiegiBastonLiegi
Update tests/test_quantum_info_random.py
cea28a9 
Co-authored-by: BrunoLiegiBastonLiegi <45011234+BrunoLiegiBastonLiegi@users.noreply.github.com>
BrunoLiegiBastonLiegi
BrunoLiegiBastonLiegi approved these changes Jan 29, 2024
View reviewed changes
tests/test_quantum_info_random.py Outdated Show resolved Hide resolved
@renatomello @BrunoLiegiBastonLiegi
Update tests/test_quantum_info_random.py
1a2c6d7 
Co-authored-by: BrunoLiegiBastonLiegi <45011234+BrunoLiegiBastonLiegi@users.noreply.github.com>
@MatteoRobbiati MatteoRobbiati self-requested a review January 31, 2024 09:13
@renatomello renatomello added this pull request to the merge queue Feb 3, 2024
Merged via the queue into master with commit 6c5223d Feb 3, 2024
19 checks passed
@renatomello renatomello deleted the refactor_seed branch February 3, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi approved these changes

@AlejandroSopena AlejandroSopena AlejandroSopena approved these changes

@stavros11 stavros11 Awaiting requested review from stavros11

@MatteoRobbiati MatteoRobbiati Awaiting requested review from MatteoRobbiati

Assignees

@renatomello renatomello

Labels
enhancement New feature or request quantum_info module PRs and issues related to the quantum information module
Projects
None yet
Milestone
Qibo 0.2.5
Development

Successfully merging this pull request may close these issues.
3 participants
@renatomello @AlejandroSopena @BrunoLiegiBastonLiegi