-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deadlock when calling datasource manager dialog refresh #60495
base: master
Are you sure you want to change the base?
Fix deadlock when calling datasource manager dialog refresh #60495
Conversation
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
It seems to me the issue still occurs (#60335 (comment)) even using the MinGW64 built from this PR. |
do you have a stacktrace ? |
Sort of the same debug messages:
then QGIS hangs indefinitely. |
This do not load the metadata unless the widget is visible. It is an attempt to fix qgis#60335 (which I cannot reproduce after the previous commit)
@agiudiceandrea thanks, that looks actually different: the previous stacktrace was originated from the metadata widget refresh (that I fixed with 0d77262 ). This last stacktrace error comes from the browser widget. |
These are the debug messages following the other way to replicate the issue:
then QGIS hangs indefinitely. |
@agiudiceandrea I'm trying hard but I cannot reproduce the issue (my postgres server is down so I have a lot of broken connections that trigger the credentials dialog). I am shooting in the dark here. Can you please check if my last commit fixes the issue ? |
Sure, when it will be ready. Have you tried using a brand new QGIS user profile? The issue occurs regardless of the PostgreSQL server is up or down or if it is installed or not in the system. This is the third way to replicate the issue:
|
Yes, I mean this is my way to trigger the credentials dialog because if the server is up QGIS connects without asking for credentials and the credentials dialog never appears. |
It seems to me I cannot replicate the issue using the latest MinGW64 build at e1cc7c2 from https://github.com/qgis/QGIS/actions/runs/13196488609?pr=60495. |
|
test done, |
Fix #60335