Mention in the docs that to_string is not locale-aware #60479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elpaso
added
GUI/UX
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
rouault
approved these changes
Feb 6, 2025
| @@ -5,11 +5,11 @@ | |||
| "description": "Converts a number to string.", | |||
| "arguments": [{ | |||
| "arg": "number", | |||
| "description": "Integer or real value. The number to convert to string." | |||
| "description": "Integer or real value. The number to convert to string. The conversion is not locale-aware, see 'format_number' for a locale-aware alternative." | |||
There was a problem hiding this comment.
Wouldn't it be better to add the note to the function description, instead of the argument description?
This was referenced Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60440