-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Clang] Remove some deprecated warnings #60428
Conversation
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
Does this hide a deprecation warning from qt? If so, I think we shouldn't do that... |
for qgsmaskpaintengine this looks like a weird clang issue/limitation, and I fail to find a way to fix it for 3D yes. What's the policy here ? Shall we disable warnings on deprecated, which could potentially lead to adding other deprecated call to the code waiting for someone to migrate to the new API ? or Shall we add Q_PUSH_NO_WARN macro and forget that we are using a deprecated API ? |
Leave the warning in place, or replace the deprecated method. Otherwise the future qt6 port will be a pain 🤪 |
56a493e
to
69c2a7f
Compare
OK, I removed 3d fix that would require to be fixed later |
69c2a7f
to
3a0a6a9
Compare
@nyalldawson OK, I removed it from this PR to keep only the openCL thing |
Because either