Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register vector tile label features first when all tiles are fetched #60361

Merged

Conversation

PatrikSylve
Copy link

This is a follow up on #60346, where the problem is described in more detail.

Problem

When rendering a map from a vector tile service, tiles are fetched asynchronously. Once a tile is fetched, its features are registered for labeling. However, the order in which the label features are registered can change depending on the order in which tiles are fetched. This results in inconsistent labeling.

Solution

Rather than registering label features when an individual tile is fetched, tiles are stored in a map. Once all tiles have been fetched, they are registered for labeling in order by tile id.

@github-actions github-actions bot added this to the 3.42.0 milestone Jan 30, 2025
Copy link

github-actions bot commented Jan 30, 2025

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit b9d47d6)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit b9d47d6)

@nyalldawson nyalldawson merged commit b3a88a2 into qgis:master Jan 31, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants