Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add picture annotation item type #58126

Merged
merged 9 commits into from
Jul 26, 2024

Conversation

nyalldawson
Copy link
Collaborator

@nyalldawson nyalldawson commented Jul 16, 2024

Can render SVG or raster images as items in an annotation layer.
Options are present for:

  • Locking the picture's aspect ratio
  • Drawing with a background symbol
  • Drawing with a border symbol
  • Linked or embedded pictures
  • Rendering with scale dependent sizes or fixed sizes

image

@nyalldawson nyalldawson added Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Jul 16, 2024
@qgis-bot
Copy link
Collaborator

@nyalldawson
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

@qgis-bot
Copy link
Collaborator

@nyalldawson

This pull request has been tagged for the changelog.

  • The description will be harvested so please provide a "nearly-ready" text for the final changelog
  • If possible, add a nice illustration of the feature. Only the first one in the description will be harvested (GIF accepted as well)
  • If you can, it's better to give credits to your sponsor, see below for different formats.

You can edit the description.

Format available for credits
  • Funded by NAME
  • Funded by URL
  • Funded by NAME URL
  • Sponsored by NAME
  • Sponsored by URL
  • Sponsored by NAME URL

Thank you!

@github-actions github-actions bot added this to the 3.40.0 milestone Jul 16, 2024
@nyalldawson
Copy link
Collaborator Author

Includes a whole bunch of other pre-requisite PRs which are patiently waiting review...

Copy link

github-actions bot commented Jul 16, 2024

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 42df827)

@nyalldawson
Copy link
Collaborator Author

@nirvn As discussed, I've now added a fixed size mode here too

@qgis qgis deleted a comment from github-actions bot Jul 18, 2024
Can render SVG or raster images as items in an annotation layer.
Options are present for:

- Locking the picture's aspect ratio
- Drawing with a background symbol
- Drawing with a border symbol
- Linked or embedded pictures
When selected, the picture annotation will always be rendered
at the same size, regardless of the map scale
@nyalldawson nyalldawson force-pushed the annotation_item_picture branch from d5d54ff to ae7321b Compare July 25, 2024 23:20
Copy link
Contributor

@nirvn nirvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, otherwise really nice addition to annotations.

@nyalldawson nyalldawson merged commit c0651bb into qgis:master Jul 26, 2024
30 checks passed
@nyalldawson nyalldawson deleted the annotation_item_picture branch July 26, 2024 10:38
@qgis-bot
Copy link
Collaborator

@nyalldawson
A documentation ticket has been opened at qgis/QGIS-Documentation#9175
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

@zacharlie zacharlie added ChangelogHarvested This PR description has been harvested in the Changelog already. and removed Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ChangelogHarvested This PR description has been harvested in the Changelog already. Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants