Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh snapping index on vector data provider notify #41357

Merged
merged 1 commit into from
Feb 8, 2021

Conversation

troopa81
Copy link
Contributor

@troopa81 troopa81 commented Feb 4, 2021

Description

Fixes #40720

When provider raise a notify message (PostGres PG_NOTIFY for instance), we have to trigger a repaint and fire a dataChanged signal so the snapping index is updated.

@troopa81 troopa81 added backport release-3_16 Bug Either a bug report, or a bug fix. Let's hope for the latter! Editing labels Feb 4, 2021
@github-actions github-actions bot added this to the 3.18.0 milestone Feb 4, 2021
@nyalldawson
Copy link
Collaborator

@OccamLabRazor Just a friendly warning -- please moderate the tone of your comments on this tracker in future. This is our workplace, and we expect you to extend the same politeness and courtesy to @troopa81 as you'd expect from him in YOUR place of work. 👍

@elpaso
Copy link
Contributor

elpaso commented Feb 5, 2021

@troopa81, let's be honest, your pull request does not solve the issue #40720.(The issue #40720 must be closed as it duplicates the problem described in #31251.)

No, they are not duplicates because the datasource is different, we do have a way to send notifications from a PG server to listening clients while there is no way for a WFS server to notify its clients.

IIRC there is a LOCK feature in WFS specs but I'm not aware of any client implementing it, it would be something different than notifications though.

@nyalldawson nyalldawson merged commit 92fc1a7 into qgis:master Feb 8, 2021
@github-actions
Copy link

github-actions bot commented Feb 8, 2021

The backport to release-3_16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-3_16 release-3_16
# Navigate to the new working tree
cd .worktrees/backport-release-3_16
# Create a new branch
git switch --create backport-41357-to-release-3_16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 92fc1a7742a6b2ff35406daa40c663344a50236c
# Push it to GitHub
git push --set-upstream origin backport-41357-to-release-3_16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-3_16

Then, create a pull request where the base branch is release-3_16 and the compare/head branch is backport-41357-to-release-3_16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Editing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vertex Tool uses old cached data resulting in corrupted data in db
3 participants