Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let gdal:convertformat convert all layers at once #39580

Closed
wants to merge 4 commits into from
Closed

Let gdal:convertformat convert all layers at once #39580

wants to merge 4 commits into from

Conversation

karatemuffin
Copy link

Problem

The gdal:convertformat(aka ogr2ogr.py) wrapper around ogr2ogr is only converting one layer of a source file at the moment.
e.g.
When setting the following options:

INPUT: https://download.geofabrik.de/europe/austria-latest.osm.pbf
OUTPUT: somefile.sqlite

they are translated to the following console command
ogr2ogr -f "SQLite" OUTPUT INPUT points
where points is describing the layer to convert, and the user isnt able to change that.

Changes

I added a Boolean Parameter to the Plugin that lets you convert all layers of a source file.
When active it eliminates the layerName being added at the end of the console command.
The default behavior to import only 1 automatically chosen layer has been kept.
Added also the Translation for the languages i speak.

@github-actions github-actions bot added this to the 3.18.0 milestone Oct 24, 2020
@gioman gioman added the Processing Relating to QGIS Processing framework or individual Processing algorithms label Oct 24, 2020
@stale
Copy link

stale bot commented Nov 7, 2020

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@stale stale bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Nov 7, 2020
Copy link
Author

@karatemuffin karatemuffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected

@stale stale bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Nov 7, 2020
@nyalldawson
Copy link
Collaborator

Manually marking as stale because stalebot has left for christmas break

@nyalldawson nyalldawson added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Dec 15, 2020
@github-actions
Copy link

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Processing Relating to QGIS Processing framework or individual Processing algorithms stale Uh oh! Seems this work is abandoned, and the PR is about to close.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants