Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backing leak #2364

Merged
merged 5 commits into from
Feb 4, 2025
Merged

Fix backing leak #2364

merged 5 commits into from
Feb 4, 2025

Conversation

kamilsa
Copy link
Contributor

@kamilsa kamilsa commented Jan 30, 2025

Referenced issues

None

Description of the Change

Properly clears bitfield and backing stores

Possible Drawbacks

None

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? Yes
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? Yes
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? yes
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. Yes

@kamilsa kamilsa requested review from iceseer and turuslan and removed request for iceseer February 3, 2025 09:29
@kamilsa kamilsa marked this pull request as ready for review February 3, 2025 09:29
@kamilsa kamilsa enabled auto-merge (squash) February 3, 2025 13:12
@iceseer iceseer disabled auto-merge February 4, 2025 08:33
@iceseer
Copy link
Contributor

iceseer commented Feb 4, 2025

clang-tidy

@kamilsa kamilsa enabled auto-merge (squash) February 4, 2025 14:01
@kamilsa kamilsa merged commit 07b82c1 into master Feb 4, 2025
13 checks passed
@kamilsa kamilsa deleted the fix/backing-leak branch February 4, 2025 14:39
igor-egorov pushed a commit that referenced this pull request Feb 10, 2025
* Fix backing leak

* Add TODO, remove onDeactivate

* Todo in enum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants