Optional metric for era points of specified validator #2361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-egorov
approved these changes
Jan 30, 2025
| @@ -786,6 +786,7 @@ namespace kagome::application { | |||
| "The global log level can be set with -l<level>.") | |||
| ("validator", "Enable validator node") | |||
| ("config-file,c", po::value<std::string>(), "Filepath to load configuration from.") | |||
| ("validator-address", po::value<std::string>(), "SS58 address, if provided, erapoints of current era for it will be sent as metric\n") | |||
There was a problem hiding this comment.
Suggested change
| ("validator-address", po::value<std::string>(), "SS58 address, if provided, erapoints of current era for it will be sent as metric\n") | |
| ("validator-address", po::value<std::string>(), "SS58 address, if provided, erapoints of current era for it will be sent as metric") |
|
|
||
| namespace kagome::state_metrics { | ||
|
|
||
| static constexpr auto SET_ERA_POINTS_PERIOD = 60; |
There was a problem hiding this comment.
Suggested change
| static constexpr auto SET_ERA_POINTS_PERIOD = 60; | |
| static constexpr auto SET_ERA_POINTS_PERIOD = 60; // in seconds |
| std::move(registry), | ||
| std::move(hasher)); | ||
| } | ||
| return nullptr; |
There was a problem hiding this comment.
I strongly disagree with the case of sptr being initialized with nullptr.
A possible solution could be wrapping it with an optional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
If validator-id is provided by cli, metric of it's era points in current era appears. Info about active era, list of validators in it and their points are taken from storage. Once a minute it's set in gauge in same registry as other metrics. If id is not validator anymore it's era points number is considered 0.
Description of the Change
Possible Drawbacks
Checklist Before Opening a PR
Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item: