Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check ubsan #2239

Merged
merged 14 commits into from
Oct 30, 2024
Merged

Check ubsan #2239

merged 14 commits into from
Oct 30, 2024

Conversation

kamilsa
Copy link
Contributor

@kamilsa kamilsa commented Oct 14, 2024

Referenced issues

https://github.com/qdrvm/KAGOME-audit/issues/41

Description of the Change

Turn on UBSAN flag that makes it abort with error message for tests.
Fix UBSAN warnings that crept into KAGOME because CI had been ignoring UBSAN reports.

Possible Drawbacks

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? Yes
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? Yes
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? Yes
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. No

@Harrm Harrm marked this pull request as ready for review October 28, 2024 11:57
@Harrm Harrm requested review from xDimon and ErakhtinB October 28, 2024 11:58
@ErakhtinB
Copy link
Contributor

Referenced issue is not mentioned in the description, is there any?

@Harrm
Copy link
Contributor

Harrm commented Oct 28, 2024

Referenced issue is not mentioned in the description, is there any?

I didn't find any. I will check in the audit repo though.

@Harrm Harrm merged commit fbbb302 into master Oct 30, 2024
16 of 21 checks passed
@Harrm Harrm deleted the fix/ubsan branch October 30, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants