Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI - version fix and cache disable option #2212

Merged
merged 11 commits into from
Sep 17, 2024
Merged

Conversation

zerg-su
Copy link
Contributor

@zerg-su zerg-su commented Sep 17, 2024

Referenced issues

Description of the Change

  1. Cache Support: Added use_cache input to control caching. Conditional caching is now implemented with actions/cache@v4 based on the use_cache flag.

  2. Checkout Optimization: Updated actions/checkout@v4 with fetch-depth: 0 for full history and added git fetch origin master:master to fetch the master branch.

  3. Cache Dependency Logic: Adjusted conditions for caching dependencies based on package_exist and use_cache flags.

  4. Minor Improvements: Small fixes in Makefile and workflow steps for version checks.

Possible Drawbacks

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? [Yes]
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? [Yes]
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? [Yes]
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. [Yes]

@zerg-su zerg-su enabled auto-merge (squash) September 17, 2024 07:32
@zerg-su zerg-su disabled auto-merge September 17, 2024 07:36
@zerg-su zerg-su enabled auto-merge (squash) September 17, 2024 07:48
@zerg-su zerg-su requested a review from xDimon September 17, 2024 07:48
@zerg-su zerg-su merged commit e785829 into master Sep 17, 2024
12 of 16 checks passed
@zerg-su zerg-su deleted the ci/build_steps_version_info branch September 17, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants