Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kagome docker push step #2098

Merged
merged 3 commits into from
May 20, 2024
Merged

Fix kagome docker push step #2098

merged 3 commits into from
May 20, 2024

Conversation

kamilsa
Copy link
Contributor

@kamilsa kamilsa commented May 20, 2024

Referenced issues

None

Description of the Change

Possible Drawbacks

  • Docker installation was moved to the end of dockerfile

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? Yes
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? Yes
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? Yes
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. No

@kamilsa kamilsa added the Non-master self-hosted Enable self-hosted runners for PR label May 20, 2024
@kamilsa kamilsa added Non-master push and removed Non-master self-hosted Enable self-hosted runners for PR labels May 20, 2024
@kamilsa kamilsa marked this pull request as ready for review May 20, 2024 08:02
@kamilsa kamilsa requested review from zerg-su and igor-egorov May 20, 2024 08:03
@kamilsa kamilsa changed the title Add docker to kagome-dev Fix kagome docker push step May 20, 2024
@kamilsa kamilsa enabled auto-merge (squash) May 20, 2024 08:04
@kamilsa kamilsa merged commit 20990e0 into master May 20, 2024
14 of 16 checks passed
@kamilsa kamilsa deleted the fix/docker-push branch May 20, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants