Fix wasm memory bug #2066
Merged
Fix wasm memory bug #2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xDimon
approved these changes
Apr 25, 2024
Comment on lines
+40
to
+45
| runtime::MemoryConfig config{kDefaultHeapBase, {}}; | ||
| auto handle = std::make_shared<MemoryImpl>(rei_->getMemory(), config); | ||
| auto allocator = | ||
| std::make_unique<runtime::MemoryAllocatorImpl>(handle, config); | ||
| allocator_ = allocator.get(); | ||
| memory_ = std::make_unique<runtime::Memory>(handle, std::move(allocator)); |
There was a problem hiding this comment.
How about combine calls for Memory assemble into single free-function?
There was a problem hiding this comment.
I thought about it, but in the end it didn't seem to be very useful, as it would eliminate just a couple of simple lines of code that create allocator across the entire code base.
turuslan
reviewed
Apr 26, 2024
turuslan
approved these changes
Apr 26, 2024
| @@ -68,7 +85,7 @@ namespace kagome::runtime { | |||
| std::optional<uint32_t> readFree(WasmPointer ptr) const; | |||
|
|
|||
| private: | |||
| Memory &memory_; | |||
| std::shared_ptr<MemoryHandle> memory_; | |||
There was a problem hiding this comment.
Rust passes Memory & to each allocate/deallocate call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
Description of the Change
Clang-15's TSAN doesn't work on new linux kernels.
Runtime Memory had a nasty circular dependency on a memory allocator, which is refactored here.
Possible Drawbacks
Checklist Before Opening a PR
Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item: