unbuffered subprocess (#2213)

qdrvm · Sep 17, 2024 · c9ce259 · c9ce259
1 parent e785829
commit c9ce259
Showing 1 changed file with 5 additions and 9 deletions.
diff --git a/core/parachain/pvf/workers.cpp b/core/parachain/pvf/workers.cpp
@@ -27,9 +27,11 @@ namespace kagome::parachain {
 
   struct ProcessAndPipes : std::enable_shared_from_this<ProcessAndPipes> {
     AsyncPipe pipe_stdin;
-    boost::asio::buffered_write_stream<AsyncPipe &> writer;
+    // NOLINTNEXTLINE(cppcoreguidelines-avoid-const-or-ref-data-members)
+    AsyncPipe &writer;
     AsyncPipe pipe_stdout;
-    boost::asio::buffered_read_stream<AsyncPipe &> reader;
+    // NOLINTNEXTLINE(cppcoreguidelines-avoid-const-or-ref-data-members)
+    AsyncPipe &reader;
     boost::process::child process;
     std::shared_ptr<Buffer> writing = std::make_shared<Buffer>();
     std::shared_ptr<Buffer> reading = std::make_shared<Buffer>();
@@ -66,13 +68,7 @@ namespace kagome::parachain {
                   if (ec) {
                     return cb(ec);
                   }
-                  self->writer.async_flush(
-                      [cb](boost::system::error_code ec, size_t) mutable {
-                        if (ec) {
-                          return cb(ec);
-                        }
-                        cb(outcome::success());
-                      });
+                  cb(outcome::success());
                 });
           });
     }