snp quic #20
Open
snp quic #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
xDimon
requested changes
Feb 17, 2025
| reading_.remote_endpoint.data(), | ||
| &len); | ||
| if (n == -1) { | ||
| if (errno == EAGAIN or errno == EWOULDBLOCK) { |
There was a problem hiding this comment.
Other errors should be handled too (i.e. shutdown connection)
There was a problem hiding this comment.
Failing to write one packet may fail some connection/stream.
Failing to write/read packets may fail some connection/stream by timeout.
I don't know why can reading opened udp socket fail, or what to to when it fails.
There was a problem hiding this comment.
i.e. case of transport (aka network interface, eth0, wifi0, etc.) is closed/ubreacheble/off
There was a problem hiding this comment.
Added error logging
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
xDimon
reviewed
Feb 25, 2025
| reading_.remote_endpoint.data(), | ||
| &len); | ||
| if (n == -1) { | ||
| if (errno == EAGAIN or errno == EWOULDBLOCK) { |
There was a problem hiding this comment.
i.e. case of transport (aka network interface, eth0, wifi0, etc.) is closed/ubreacheble/off
|
Would be better to cover new mechanics my tests... |
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./example_chatserver and./example_chat 1,./example_chat 2,./example_chat 3clients.ConnectionsConfigGenesisHashed25519::KeyPairoptional<Port> listen_portConnectionsConnections::connect(Address)Connections::serve(ProtocolId, ServeProtocol)ConnectionsControllerConnectionsController::onOpen(Key)ConnectionsController::onClose(Key)ConnectionConnection::open(ProtocolId)StreamStream::read(Bytes &message, MessageSize max)Stream::readFin()Stream::write(BytesIn message)Stream::writeFin()co_await