deprecate: Added deprecations for methods superseded by query_points #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for poetic-froyo-8baba7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
joein
requested changes
Nov 7, 2024
qdrant_client/qdrant_client.py
Outdated
Comment on lines
1055
to
1060
| warnings.warn( | ||
| "`search_matrix_pairs` method is deprecated and will be removed in the future." | ||
| " Use `query_points` instead.", | ||
| DeprecationWarning, | ||
| stacklevel=2, | ||
| ) |
There was a problem hiding this comment.
we've just introduced it, we don't want to deprecate it yet :')
qdrant_client/qdrant_client.py
Outdated
Comment on lines
1108
to
1113
| warnings.warn( | ||
| "`search_matrix_offsets` method is deprecated and will be removed in the future." | ||
| " Use `query_points` instead.", | ||
| DeprecationWarning, | ||
| stacklevel=2, | ||
| ) |
joein
approved these changes
Nov 7, 2024
joein
pushed a commit
that referenced
this pull request
Jan 16, 2025
…843) * deprecate: Added deprecations for methods superseded by query_points * deprecate: Undeprecate search_matrix_offsets and search_matrix_pairs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show deprecation message to methods that are suppressed by query_points (recommend, discover, search, context search)
All Submissions:
devbranch. Did you create your branch fromdev?New Feature Submissions:
pre-commitwithpip3 install pre-commitand set up hooks withpre-commit install?Changes to Core Features: