Local inference image support #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for poetic-froyo-8baba7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
joein
force-pushed
the
local-inference-image-support
branch
from
3c30b10 to
39ea3f8
Compare
generall
reviewed
Nov 1, 2024
| embedding_model_inst = self._get_or_init_image_model( | ||
| model_name=model_name, **(image.options or {}) | ||
| ) | ||
| image_data = base64.b64decode(image.image) |
There was a problem hiding this comment.
It does seem like a lot of overhead and not really a user-friendly interface, but I understand why it is done like this (I assume, cause we want local remove work the same)
generall
approved these changes
Nov 1, 2024
We can convert to base64 on our own, but we would either need PIL for that, or find some other ways |
* new: add inference object support * new: add inference object support * fix: remove redundant import * refactor: return newline * fix: fix propagate options test
hh-space-invader
approved these changes
Nov 4, 2024
joein
added a commit
that referenced
this pull request
Jan 16, 2025
* new: add backbone for image support * new: convert b64 to pil, embed images, add test * tests: add test file * refactor: replace 3 different inference object vars with a common one * fix: fix type hints * fix: fix type hints * tests: add tests * fix: remove redundant imports * new: propagate image options * Custom inference object (#837) * new: add inference object support * new: add inference object support * fix: remove redundant import * refactor: return newline * fix: fix propagate options test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
embed