Tsk 757 add support for tuple in payload #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We cannot test tuple as the return value is listvalue, so i only kept the list
✅ Deploy Preview for poetic-froyo-8baba7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
joein
requested changes
Sep 2, 2024
| @@ -183,6 +183,7 @@ def test_not_jsonable_payload(): | |||
| {"frozenset": frozenset([1, 2])}, | |||
| {"set": {1, 2}}, | |||
| {"uuid": uuid.uuid4()}, | |||
| {"listvalue": [1, 1]}, | |||
There was a problem hiding this comment.
I think it should be tested somewhere else
This test is about not jsonable types in payload, however lists and tuples are jsonable
e.g.
>>> import json
>>> json.dumps({"a": (1,2)})
'{"a": [1, 2]}'
There was a problem hiding this comment.
Could we maybe add it to the random payload generator in fixtures?
|
why do we need this? |
|
joein
approved these changes
Sep 9, 2024
joein
pushed a commit
that referenced
this pull request
Sep 16, 2024
* Add support for tuple in payload for grpc * chore: delete health_check_pb2_grpc.py * chore: Modify payload test case to test tuple datatype * chore: Removed test case for tuple We cannot test tuple as the return value is listvalue, so i only kept the list * chore: Remove excess prints in info endpoint * chore: Added tuple in random payload generator * feat: convert the tuple payload of local mode to list for congruence
hh-space-invader
deleted the
TSK-757-add-support-for-tuple-in-payload
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
devbranch. Did you create your branch fromdev?New Feature Submissions:
pre-commitwithpip3 install pre-commitand set up hooks withpre-commit install?Changes to Core Features: