added new to type stub + fixed type hinting #717
Merged
+601
−518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for poetic-froyo-8baba7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
could you also unlock |
|
other than the comments, looks fine |
joein
requested changes
Aug 7, 2024
hh-space-invader
force-pushed
the
fix-type-hinting
branch
from
7ae803a to
fe586da
Compare
hh-space-invader
force-pushed
the
fix-type-hinting
branch
from
fe586da to
21e93d5
Compare
|
could you please regenerate poetry.lock |
joein
requested changes
Aug 8, 2024
| @@ -62,16 +62,16 @@ def get_args_subscribed(tp): # type: ignore | |||
| rest.PayloadSchemaType, rest.PayloadSchemaParams, int, grpc.PayloadIndexParams | |||
| ] # type(grpc.PayloadSchemaType) == int | |||
| PointStruct: TypeAlias = rest.PointStruct | |||
| Points = Union[rest.Batch, List[Union[rest.PointStruct, grpc.PointStruct]]] | |||
| Points = Union[rest.Batch, Sequence[Union[rest.PointStruct, grpc.PointStruct]]] | |||
There was a problem hiding this comment.
LocalCollection.upsert should become Union[Sequence[models.PointStruct], models.Batch] then
joein
approved these changes
Aug 8, 2024
joein
added a commit
that referenced
this pull request
Aug 12, 2024
* added new to type stub + fixed type hinting * unlocked pyright + updated type_stub * updated poetry lock * fix: fix local collection upsert type hint --------- Co-authored-by: George Panchuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
devbranch. Did you create your branch fromdev?New Feature Submissions:
pre-commitwithpip3 install pre-commitand set up hooks withpre-commit install?Changes to Core Features: