new: extend query interface with documents #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for poetic-froyo-8baba7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
joein
force-pushed
the
extend-query-interface
branch
from
ed19a09 to
5a897d6
Compare
generall
approved these changes
Jul 31, 2024
joein
added a commit
that referenced
this pull request
Aug 12, 2024
* new: extend query interface with documents * new: add named additional types * fix: add missing changes to generator * new: modify openapi instead of models py * fix: avoid wildcard interpretation by shell * new: replace structure extension method * fix: update embed models and type aliases * fix: add accidentally removed file * fix: r u happy mypy? * fix: fix branch name in generator
I8dNLo
pushed a commit
that referenced
this pull request
Jan 16, 2025
* new: extend query interface with documents * new: add named additional types * fix: add missing changes to generator * new: modify openapi instead of models py * fix: avoid wildcard interpretation by shell * new: replace structure extension method * fix: update embed models and type aliases * fix: add accidentally removed file * fix: r u happy mypy? * fix: fix branch name in generator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends query interface with additional types accepted by fastembed or cloud inference service
This PR updates such structures as
VectorInput,VectorStruct,BatchVectorStructIt updates these structures in an explicit way, so the new types are added directly, like
Document,List[Document],Dict[StrictStr, Document]andDict[StrictStr, List[Document]correspondingly.An alternative could be an extension of
Vectortype, but the problem is, that, e.g. inBatchVectorStructwe can't just addList[Vector], cause it will lead to inconsistencies with sparse vectors behaviour, which can only be named.