Random sample in local mode #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agourlay
reviewed
Jul 23, 2024
| remote_client = init_remote(prefer_grpc=prefer_grpc) | ||
| init_client(remote_client, fixture_points) | ||
|
|
||
| compare_client_results(local_client, remote_client, searcher.random_query) |
There was a problem hiding this comment.
Why are the random implementations between local and server equivalent?
I would expect those to return different values.
There was a problem hiding this comment.
In this test we basically sample all the points available in the collection
In random_query we use limit=100 and we generate 100 points in fixture_points = generate_fixtures(100)
There was a problem hiding this comment.
We return all points postprocessed to be sorted by ID. Just to make sure we can return all of them
joein
reviewed
Jul 25, 2024
joein
reviewed
Jul 25, 2024
joein
reviewed
Jul 25, 2024
joein
reviewed
Jul 25, 2024
joein
reviewed
Jul 25, 2024
joein
reviewed
Jul 25, 2024
Comment on lines
+1793
to
+1799
| random_scores = np.random.rand(len(self.ids)) | ||
| random_order = np.argsort(random_scores) |
There was a problem hiding this comment.
nit: np.random.permutation(self.inv_ids)
There was a problem hiding this comment.
but we need the internal ids to filter against the mask, not the external ones
|
my comments are mostly nit, other than that looks good |
joein
approved these changes
Jul 30, 2024
joein
force-pushed
the
random-sample-local-mode
branch
from
c49579f to
41c2fd5
Compare
joein
added a commit
that referenced
this pull request
Aug 8, 2024
* pre-implement random sampling * generate models * add conversions and tests * fix mypy lints * tests: add test for sample random conversion * use camelcase Sample.Random * review fixes * fix mypy --------- Co-authored-by: George Panchuk <[email protected]>
joein
added a commit
that referenced
this pull request
Aug 9, 2024
* universal-search: Query Group API and local mode * requires different logic for gRPC error assertion * you come to me at runtime for a compile time issue * suddenly throwing a different error * test more group key types * extend limit of prefetches during group_by * rescoring is the issue * one problem at a time please * code review * regen clients * code review * add lookup_from to query_points_groups * test with_lookup * test and fix gRPC * drop dedicated conversion * Update qdrant_client/qdrant_client.py Co-authored-by: Luis Cossío <[email protected]> * regen async * Distribution-based score fusion in local mode (#703) * pre-implement dbsf * add dbsf congruence tests * mypy lints * add conversions * tests: add test for dbsf conversion --------- Co-authored-by: George Panchuk <[email protected]> * Random sample in local mode (#705) * pre-implement random sampling * generate models * add conversions and tests * fix mypy lints * tests: add test for sample random conversion * use camelcase Sample.Random * review fixes * fix mypy --------- Co-authored-by: George Panchuk <[email protected]> * fix: add type ignore for mypy * fix: fix type hints for 3.8 * fix: do not run mypy on async client generator in CI, simplify condition * Grpc comparison in tests (#726) * add parametrized fixture for using grpc too * compare grpc and http without running each setup twice * fix: fix exception types in invalid types test * fix: remove random seed which led to a erroneous sequence --------- Co-authored-by: Luis Cossío <[email protected]> --------- Co-authored-by: Luis Cossío <[email protected]> Co-authored-by: George Panchuk <[email protected]>
joein
added a commit
that referenced
this pull request
Aug 12, 2024
* universal-search: Query Group API and local mode * requires different logic for gRPC error assertion * you come to me at runtime for a compile time issue * suddenly throwing a different error * test more group key types * extend limit of prefetches during group_by * rescoring is the issue * one problem at a time please * code review * regen clients * code review * add lookup_from to query_points_groups * test with_lookup * test and fix gRPC * drop dedicated conversion * Update qdrant_client/qdrant_client.py Co-authored-by: Luis Cossío <[email protected]> * regen async * Distribution-based score fusion in local mode (#703) * pre-implement dbsf * add dbsf congruence tests * mypy lints * add conversions * tests: add test for dbsf conversion --------- Co-authored-by: George Panchuk <[email protected]> * Random sample in local mode (#705) * pre-implement random sampling * generate models * add conversions and tests * fix mypy lints * tests: add test for sample random conversion * use camelcase Sample.Random * review fixes * fix mypy --------- Co-authored-by: George Panchuk <[email protected]> * fix: add type ignore for mypy * fix: fix type hints for 3.8 * fix: do not run mypy on async client generator in CI, simplify condition * Grpc comparison in tests (#726) * add parametrized fixture for using grpc too * compare grpc and http without running each setup twice * fix: fix exception types in invalid types test * fix: remove random seed which led to a erroneous sequence --------- Co-authored-by: Luis Cossío <[email protected]> --------- Co-authored-by: Luis Cossío <[email protected]> Co-authored-by: George Panchuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements random sampling in local mode and adds the required conversions