Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix grpc conversion bugs for sparse and multi vectors #682

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

joein
Copy link
Member

@joein joein commented Jul 8, 2024

this pr fixes 2 bugs

  1. search with sparse vectors via query with grpc
  2. upsert multivec points with grpc

@joein joein requested a review from coszio July 8, 2024 16:17
Copy link

netlify bot commented Jul 8, 2024

Deploy Preview for poetic-froyo-8baba7 ready!

Name Link
🔨 Latest commit 0023567
🔍 Latest deploy log https://app.netlify.com/sites/poetic-froyo-8baba7/deploys/668c1152536d500008f5bc00
😎 Deploy Preview https://deploy-preview-682--poetic-froyo-8baba7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@coszio coszio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, we were using the global instead of the local variable... model -> vector.

And now we are also converting from query_interface 👍

@joein joein merged commit fb7e396 into dev Jul 8, 2024
14 checks passed
joein added a commit that referenced this pull request Jul 8, 2024
* fix: fix grpc conversion bugs for sparse and multi vectors

* fix: fix mypy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants