Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break out of retry loop upon successful upsert #531

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

almostimplemented
Copy link
Contributor

All Submissions:

  • [ X ] Contributions should target the dev branch. Did you create your branch from dev?
  • [ X ] Have you followed the guidelines in our Contributing document?
  • [ X ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Discussion:

The current retry logic in the uploader code invokes the upsert operation max_retries times, regardless of whether the request succeeds or fails. Then, an exception is raised if the last of the attempts fails. The code should instead break upon a successful request and return True.

Copy link

netlify bot commented Mar 11, 2024

Deploy Preview for poetic-froyo-8baba7 ready!

Name Link
🔨 Latest commit ba03064
🔍 Latest deploy log https://app.netlify.com/sites/poetic-froyo-8baba7/deploys/65ef0799c24d970008185514
😎 Deploy Preview https://deploy-preview-531--poetic-froyo-8baba7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joein joein merged commit 6d1fcde into qdrant:dev Mar 11, 2024
14 checks passed
@generall
Copy link
Member

Hey @almostimplemented, thanks a lot for fixing! 🙏

@amitshukla-evs
Copy link

It was a bit worrisome to see so many outgoing calls to qdrant server in the logs. I am really glad to find that it has been fixed and merged.

@joein When could we expect this fix to be released?

@joein
Copy link
Member

joein commented Mar 15, 2024

@amitshukla-evs hopefully this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants