refactor: use list_supported_models() from FastEmbed #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anush008
force-pushed
the
list_supported_models
branch
from
fd75dbd to
f6392ab
Compare
NirantK
approved these changes
Feb 21, 2024
NirantK
merged commit 0803fb5
into
nirant/upgrade-fastembed-version
5 of 10 checks passed
joein
pushed a commit
that referenced
this pull request
Mar 2, 2024
joein
pushed a commit
that referenced
this pull request
Mar 4, 2024
joein
added a commit
that referenced
this pull request
Mar 5, 2024
* Update fastembed to v0.2.1 * chore(qdrant_fastembed.py): update DEFAULT_EMBEDDING_MODEL * fix(fastembed integration): upgrade to latest version * Prefer black over ruff * Prefer black over ruff * Remove hardcoded directory structure from Qdrant Client checks * new: deprecate current default model, deprecate max token length, update fastembed * fix: make embedding_model_name method sync * fix: update poetry lock * refactor: use list_supported_models() (#501) * fix: fix fastembed check * fix: fix fastembed class var assignment * fix: remove fastembed deprecation from qdrant client (#524) --------- Co-authored-by: George Panchuk <[email protected]> Co-authored-by: Anush <[email protected]>
joein
added a commit
that referenced
this pull request
Mar 5, 2024
* Update fastembed to v0.2.1 * chore(qdrant_fastembed.py): update DEFAULT_EMBEDDING_MODEL * fix(fastembed integration): upgrade to latest version * Prefer black over ruff * Prefer black over ruff * Remove hardcoded directory structure from Qdrant Client checks * new: deprecate current default model, deprecate max token length, update fastembed * fix: make embedding_model_name method sync * fix: update poetry lock * refactor: use list_supported_models() (#501) * fix: fix fastembed check * fix: fix fastembed class var assignment * fix: remove fastembed deprecation from qdrant client (#524) --------- Co-authored-by: George Panchuk <[email protected]> Co-authored-by: Anush <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To be merged into the
upgrade-fastembed-versionbranch. #493.Updates
qdrant_fastembed.pyandasync_qdrant_fastembed.pyto uselist_supported_models()from FastEmbed to set theSUPPORTED_MODELSvalue.Resolves qdrant/fastembed#95.
New Feature Submissions:
pre-commitwithpip3 install pre-commitand set up hooks withpre-commit install?