Fix Vector Count Mismatch during Client Migration #403 #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…during client migration. The problem was due to missing in the calls. This commit adds to ensure proper synchronization and resolves the vector count mismatch.
✅ Deploy Preview for poetic-froyo-8baba7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
joein
reviewed
Jan 11, 2024
There was a problem hiding this comment.
Thank you for your interest and contribution!
I guess we may have more complaints about timeouts with these changes, but let's try it out
It also does not make a lot of sense to me to add wait parameter to the _migrate_collection signature, since it is not exposed to the user
And I don't want to make the signature of migrate more complex
joein
added a commit
that referenced
this pull request
Jan 19, 2024
* Addresses issue #403 where the vector counts were inconsistent during client migration. The problem was due to missing in the calls. This commit adds to ensure proper synchronization and resolves the vector count mismatch. * Update qdrant_client/migrate/migrate.py * Update qdrant_client/migrate/migrate.py --------- Co-authored-by: George <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client Migration Fix
Resolve vector count mismatch during client migration. The problem was due to missing
<wait=True>in the<upload_records>calls. This commit adds<wait=True>to ensure proper synchronization and resolves the vector count mismatch.All Submissions:
devbranch. (Yes, created branch fromdev)New Feature Submissions:
pre-commitwithpip3 install pre-commitand set up hooks withpre-commit install?Changes to Core Features: