Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix division by zero in cosine similarity in local mode #425

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

joein
Copy link
Member

@joein joein commented Jan 6, 2024

numpy does not raise an exception in case of division by zero, but instead emits RuntimeWarning about invalid elements

Copy link

netlify bot commented Jan 6, 2024

Deploy Preview for poetic-froyo-8baba7 ready!

Name Link
🔨 Latest commit f3554ea
🔍 Latest deploy log https://app.netlify.com/sites/poetic-froyo-8baba7/deploys/65989ac486b20e0008df3538
😎 Deploy Preview https://deploy-preview-425--poetic-froyo-8baba7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joein joein requested a review from generall January 6, 2024 02:03
@joein joein merged commit ccebf83 into dev Jan 6, 2024
14 checks passed
@generall generall deleted the fix-division-by-zero-cosine branch May 3, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants