Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new: add shard keys to upload_collection and upload_records #396

Merged
merged 3 commits into from
Jan 5, 2024
Merged

new: add shard keys to upload_collection and upload_records #396

merged 3 commits into from
Jan 5, 2024

Conversation

joein
Copy link
Member

@joein joein commented Dec 7, 2023

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you installed pre-commit with pip3 install pre-commit and set up hooks with pre-commit install?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them? Add custom shard key to upload_collection #392
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@netlify Netlify
Copy link

netlify bot commented Dec 7, 2023 •
edited
Loading

✅ Deploy Preview for poetic-froyo-8baba7 ready!

Name Link
🔨 Latest commit bed3f6e
🔍 Latest deploy log https://app.netlify.com/sites/poetic-froyo-8baba7/deploys/65984fdbfaf18700085d3fe4
😎 Deploy Preview https://deploy-preview-396--poetic-froyo-8baba7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joein joein requested a review from generall December 7, 2023 18:52
@joein
new: remove split by batch (#422)
bed3f6e 
* new: remove split by batch

* fix: fix type hints, remove redundant arg

* fix: fix mypy

* new: ignore shard keys from records

* new: add warning if shard key is set in records in upload_records
@joein joein merged commit 3e7c743 into dev Jan 5, 2024
14 checks passed
@joein joein mentioned this pull request Jan 6, 2024
Closed
joein added a commit that referenced this pull request Jan 19, 2024
@joein
new: add shard keys to upload_collection and upload_records (#396)
48a21cb 
* new: add shard keys to upload_collection and upload_records

* fix: update async client, update type hint

* new: remove split by batch (#422)

* new: remove split by batch

* fix: fix type hints, remove redundant arg

* fix: fix mypy

* new: ignore shard keys from records

* new: add warning if shard key is set in records in upload_records
@generall generall deleted the upload-collection-shard-key branch May 3, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@generall generall generall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joein @generall