Recommendation api update + local mode #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
generall
commented
Sep 25, 2023
•
generall
commented
- Implement support for vectors and strategy in reco API
- local mode
|
New tests are failing at the moment, there is difference in the score precision being generated in local mode, apparently. Will continue tomorrow |
coszio
changed the title
joein
reviewed
Sep 28, 2023
qdrant_client/qdrant_remote.py
Outdated
Comment on lines
811
to
816
| RestToGrpc.convert_extended_point_id(example) | ||
| if isinstance(example, get_args_subscribed(models.ExtendedPointId)) | ||
| else example | ||
| for example in positive | ||
| if isinstance(example, get_args_subscribed(models.ExtendedPointId)) | ||
| or isinstance(example, grpc.PointId) |
| @@ -118,7 +118,7 @@ def compare_scored_record( | |||
| point1.id == point2.id | |||
| ), f"point1[{idx}].id = {point1.id}, point2[{idx}].id = {point2.id}" | |||
| assert ( | |||
| point1.score - point2.score < 1e-4 | |||
| abs(point1.score / point2.score - 1) < 1e-4 | |||
There was a problem hiding this comment.
Is it actually better?
I can see the concern about abs, but with the division it is not clear for me
I don't mind, but it should be checked for a division by zero
There was a problem hiding this comment.
new reco was failing because for only negatives recommendation, scores can be in the magnitude of hundreds, which needed to either
- Decrease precision check
or - "Normalize" the scores
But then it is true that we get into division by zero errors
There was a problem hiding this comment.
Resorted to another solution: adjust the precision based on the magnitude of the score
joein
reviewed
Sep 28, 2023
coszio
force-pushed
the
update-reco-api
branch
from
cf31d2f to
04835b0
Compare
generall
added a commit
that referenced
this pull request
Oct 6, 2023
* WIP: recommendation api update * implement local new reco + add new tests * refactor calculate_best_scores, normalize score assertion * fix raw vectors in new recommend * fix mypy errors, add new reco on group recommend * fix more lints from ci * fix pyright lint * formattng * Add descriptions to enums * no mutable default argument * edit score comparison precision based on magnitude * Address review comments * remove custom message for type ignore * add coverage test * improve coverage test a little * add more fixtures for conversion test --------- Co-authored-by: Luis Cossío <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.