Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for vector operations #275

Merged
merged 3 commits into from
Sep 4, 2023
Merged

add tests for vector operations #275

merged 3 commits into from
Sep 4, 2023

Conversation

generall
Copy link
Member

@generall generall commented Aug 31, 2023

Fixes #270.

@generall generall requested a review from timvisee August 31, 2023 18:07
Copy link
Member

@timvisee timvisee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Tested it locally with the snippet that previously failed as well, and that works fine now (with vectors=).

I do see an issue with our argument name though, please see my comment below:

@@ -1075,7 +1075,7 @@ def update_vectors(
grpc.UpdatePointVectors(
collection_name=collection_name,
wait=wait,
vectors=vectors,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our Python client now still uses vectors, while our gRPC/REST API uses points.

Our documentation also suggests to use points: https://qdrant.tech/documentation/concepts/points/#update-vectors

I prefer points because you provide a list of points (with vectors), and not a list of vectors directly.

Do we leave as is and update our documentation, or do we switch to points? I like the latter better.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's switch

@generall generall merged commit 578db81 into dev Sep 4, 2023
generall added a commit that referenced this pull request Sep 7, 2023
* add tests for vector operations

* rename vectors->points in vector update API

* fix tests
@generall generall deleted the fix-vectors-update branch May 3, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants