Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Methods
value_counts
,isempty
,isnull
didn't work properly in local mode due to an approach when we flatten all input values into one arrayFor instance if we have the following payload:
{"nested": [{"numeric": 1, "numeric": 2, "numeric": 3}]}
and want to filter by value count ofnumeric
, then local mode piles up everything into one array and counts them together (values_count=3
), but it should count them separately (values_count=1
)Another problem with payload like
{"nested": [{"empty": [None]}, {"empty": [None]}, {"empty": [None]}
or
{"nones": [None, None]}
Local mode considers such fields equal to
None
, however[None, None] != None
.This PR adjusts interface of
payload_value_extractor
and allows to disable flattening during an extraction of values.All Submissions:
dev
branch. Did you create your branch fromdev
?New Feature Submissions:
pre-commit
withpip3 install pre-commit
and set up hooks withpre-commit install
?Changes to Core Features: