Fixes for test, type errors #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n QdrantFastembedMixin class * fix(qdrant_fastembed.py): change method name from encode to embed
…ence-transformers/all-MiniLM-L6-v2" to "BAAI/bge-small-en"
… in QdrantFastembedMixin * feat(qdrant_fastembed.py): add embed_type parameter to embed method in QdrantFastembedMixin
…l_name}" to "fast-{model_name}"
…to simplify parameter handling and remove unnecessary checks and assignments
✅ Deploy Preview for poetic-froyo-8baba7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…_embed` in QdrantFastembedMixin class * fix(qdrant_fastembed.py): fix query_vectors assignment in `query` method of QdrantFastembedMixin class
generall
approved these changes
Aug 23, 2023
generall
pushed a commit
that referenced
this pull request
Sep 7, 2023
* * fix(qdrant_fastembed.py): change method name from encode to embed in QdrantFastembedMixin class
* fix(qdrant_fastembed.py): change method name from encode to embed
* * fix(qdrant_fastembed.py): change DEFAULT_EMBEDDING_MODEL from "sentence-transformers/all-MiniLM-L6-v2" to "BAAI/bge-small-en"
* * fix(qdrant_fastembed.py): add support for different embedding types in QdrantFastembedMixin
* feat(qdrant_fastembed.py): add embed_type parameter to embed method in QdrantFastembedMixin
* * fix(qdrant_fastembed.py): change vector field name from "text-{model_name}" to "fast-{model_name}"
* * fix(qdrant_fastembed.py): add comments to clarify code intent
* * refactor(qdrant_fastembed.py): remove unused import 'Sequence' from typing module
* * test(test_fast_embed.py): refactor test_add_without_query function to simplify parameter handling and remove unnecessary checks and assignments
* * fix(qdrant_fastembed.py): fix type error in NamedVector Query
* * fix(qdrant_fastembed.py): change method name from `embed` to `query_embed` in QdrantFastembedMixin class
* fix(qdrant_fastembed.py): fix query_vectors assignment in `query` method of QdrantFastembedMixin class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on the API Change brnach, to be reviewed after that has been merged