fix(dondominio): remove unneeded name field

qdm12 · Aug 21, 2024 · c7dbbcb · c7dbbcb
1 parent 8f45697
commit c7dbbcb
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 10 deletions.
diff --git a/docs/dondominio.md b/docs/dondominio.md
@@ -10,7 +10,6 @@
     {
       "provider": "dondominio",
       "domain": "domain.com",
-      "name": "something",
       "username": "username",
       "key": "key",
       "ip_version": "ipv4",
@@ -23,7 +22,6 @@
 ### Compulsory parameters
 
 - `"domain"` is the domain to update. It can be `example.com` (root domain), `sub.example.com` (subdomain of `example.com`) or `*.example.com` for the wildcard.
-- `"name"` is the name of the service/hosting
 - `"username"`
 - `"password"`
 

diff --git a/internal/provider/errors/validation.go b/internal/provider/errors/validation.go
@@ -24,7 +24,6 @@ var (
 	ErrIPv6KeyNotSet          = errors.New("IPv6 key is not set")
 	ErrKeyNotSet              = errors.New("key is not set")
 	ErrKeyNotValid            = errors.New("key is not valid")
-	ErrNameNotSet             = errors.New("name is not set")
 	ErrPasswordNotSet         = errors.New("password is not set")
 	ErrPasswordNotValid       = errors.New("password is not valid")
 	ErrSecretKeyNotSet        = errors.New("secret key is not set")

diff --git a/internal/provider/providers/dondominio/provider.go b/internal/provider/providers/dondominio/provider.go
@@ -24,7 +24,6 @@ type Provider struct {
 	ipv6Suffix netip.Prefix
 	username   string
 	key        string
-	name       string
 }
 
 func New(data json.RawMessage, domain, owner string,
@@ -34,7 +33,6 @@ func New(data json.RawMessage, domain, owner string,
 		Username string `json:"username"`
 		Password string `json:"password"` // retro-compatibility
 		Key      string `json:"key"`
-		Name     string `json:"name"`
 	}{}
 	err = json.Unmarshal(data, &extraSettings)
 	if err != nil {
@@ -47,7 +45,7 @@ func New(data json.RawMessage, domain, owner string,
 		extraSettings.Key = extraSettings.Password
 	}
 
-	err = validateSettings(domain, extraSettings.Username, extraSettings.Key, extraSettings.Name)
+	err = validateSettings(domain, extraSettings.Username, extraSettings.Key)
 	if err != nil {
 		return nil, fmt.Errorf("validating provider specific settings: %w", err)
 	}
@@ -59,11 +57,10 @@ func New(data json.RawMessage, domain, owner string,
 		ipv6Suffix: ipv6Suffix,
 		username:   extraSettings.Username,
 		key:        extraSettings.Key,
-		name:       extraSettings.Name,
 	}, nil
 }
 
-func validateSettings(domain, username, key, name string) (err error) {
+func validateSettings(domain, username, key string) (err error) {
 	err = utils.CheckDomain(domain)
 	if err != nil {
 		return fmt.Errorf("%w: %w", errors.ErrDomainNotValid, err)
@@ -74,8 +71,6 @@ func validateSettings(domain, username, key, name string) (err error) {
 		return fmt.Errorf("%w", errors.ErrUsernameNotSet)
 	case key == "":
 		return fmt.Errorf("%w", errors.ErrKeyNotSet)
-	case name == "":
-		return fmt.Errorf("%w", errors.ErrNameNotSet)
 	}
 	return nil
 }