New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ArrayParameter in DoNds #196

Closed

Dominik-Vogel wants to merge 1 commit into qdev-dk:master from Dominik-Vogel:Dond_ArrayParameter

Contributor

Dominik-Vogel commented Nov 28, 2019 •

edited

Loading

This is inspired by #166

see diff here:
80516e7...ThorvaldLarsen:doNd_save_image


          Add support for ArrayParameter

06b8490

Contributor Author

Dominik-Vogel commented Nov 28, 2019

@ThorvaldLarsen what is this sleep about?
https://github.com/ThorvaldLarsen/qdev-wrappers/blob/9df2e3359804a9dc4e9172a7de4194abb25e8080/qdev_wrappers/dataset/doNd.py#L112

Contributor Author

Dominik-Vogel commented Nov 28, 2019

I have looked at the test and realized, that it is not actually necessary. Maybe it was when the changes first were made.
@ThorvaldLarsen
https://github.com/QCoDeS/Qcodes/blob/bc0118c1ee4b5a4f54b2a56bf2dbe1adcde4b59f/qcodes/dataset/measurements.py#L869-L896

Dominik-Vogel closed this

Contributor

jenshnielsen commented Nov 28, 2019

The multiparameter part is afaik still not handled within qcodes

Contributor Author

Dominik-Vogel commented Nov 28, 2019

True, but this we should handle in qcodes.

Collaborator

ThorvaldLarsen commented Nov 28, 2019

Not sure about the sleep. Also this PR is quite old so seems very plausible that what it solved has since been fixed in qcodes.

Collaborator

ThorvaldLarsen commented Nov 28, 2019

Well not this PR, but the original one I made to handle array paramters with new dataset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet