Skip to content

Commit

Permalink
Use compact format for JSON files
Browse files Browse the repository at this point in the history
It saves a bit of space on disk and deters novice users from tampering them.

PR #22211.
  • Loading branch information
Chocobo1 authored Jan 29, 2025
1 parent af65ddd commit f853616
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/base/rss/feed_serializer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ void RSS::Private::FeedSerializer::store(const Path &dataFileName, const QList<Q
arr << jsonObj;
}

const nonstd::expected<void, QString> result = Utils::IO::saveToFile(dataFileName, QJsonDocument(arr).toJson());
const nonstd::expected<void, QString> result = Utils::IO::saveToFile(dataFileName, QJsonDocument(arr).toJson(QJsonDocument::Compact));
if (!result)
{
LogMsg(tr("Failed to save RSS feed in '%1', Reason: %2").arg(dataFileName.toString(), result.error())
Expand Down
4 changes: 2 additions & 2 deletions src/gui/search/searchwidget.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -873,7 +873,7 @@ void SearchWidget::DataStorage::storeSession(const SessionData &sessionData)
};

const Path sessionFilePath = makeDataFilePath(SESSION_FILE_NAME);
const auto saveResult = Utils::IO::saveToFile(sessionFilePath, QJsonDocument(sessionObj).toJson());
const auto saveResult = Utils::IO::saveToFile(sessionFilePath, QJsonDocument(sessionObj).toJson(QJsonDocument::Compact));
if (!saveResult)
{
LogMsg(tr("Failed to save Search UI state. File: \"%1\". Error: \"%2\"")
Expand Down Expand Up @@ -905,7 +905,7 @@ void SearchWidget::DataStorage::storeTab(const QString &tabID, const QList<Searc
}

const Path filePath = makeDataFilePath(tabID + u".json");
const auto saveResult = Utils::IO::saveToFile(filePath, QJsonDocument(searchResultsArray).toJson());
const auto saveResult = Utils::IO::saveToFile(filePath, QJsonDocument(searchResultsArray).toJson(QJsonDocument::Compact));
if (!saveResult)
{
LogMsg(tr("Failed to save search results. Tab: \"%1\". File: \"%2\". Error: \"%3\"")
Expand Down

0 comments on commit f853616

Please sign in to comment.