-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize memory usage when stream flush and save #659
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @snowcrumble, thanks for your PR. I've left some comments. Please make sure to pass the go test
.
Codecov Report
@@ Coverage Diff @@
## v2 #659 +/- ##
==========================================
- Coverage 95.59% 95.53% -0.06%
==========================================
Files 31 31
Lines 8442 8441 -1
==========================================
- Hits 8070 8064 -6
- Misses 225 229 +4
- Partials 147 148 +1
Continue to review full report at Codecov.
|
this change will be very helpful for me
I found few things not working in streaming API:
dateFormat := "[$-409]m/d/yy hh:mm;@"
dateStyle, err := file.NewStyle(&excelize.Style{CustomNumFmt: &dateFormat})
for ... {
excelRow = append(excelRow, excelize.Cell{Value: val, StyleID: dateFormat})
}
|
# Conflicts: # go.mod # go.sum
* use io.Copy from stream temp file to zip Writer * fix nil * log * build * delete log * fix compatibility for office * Update go module Co-authored-by: lijingfeng <[email protected]> Co-authored-by: xuri <[email protected]>
* use io.Copy from stream temp file to zip Writer * fix nil * log * build * delete log * fix compatibility for office * Update go module Co-authored-by: lijingfeng <[email protected]> Co-authored-by: xuri <[email protected]>
PR Details
Optimize memory usage when stream flush and save
Description
Related Issue
#650
Motivation and Context
Avoid instantaneous memory usage.
How Has This Been Tested
I fix a OOM problem in k8s.
Types of changes
Checklist