Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #533, add support overlapped mergecells #536

Merged
merged 1 commit into from
Dec 15, 2019

Conversation

match-meng
Copy link
Contributor

PR Details

Description

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-io
Copy link

codecov-io commented Dec 14, 2019

Codecov Report

Merging #536 into master will increase coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #536     +/-   ##
=========================================
+ Coverage   96.47%   96.67%   +0.2%     
=========================================
  Files          28       28             
  Lines        5729     5751     +22     
=========================================
+ Hits         5527     5560     +33     
+ Misses        110      104      -6     
+ Partials       92       87      -5
Impacted Files Coverage Δ
xmlWorksheet.go 100% <ø> (ø) ⬆️
adjust.go 96.29% <ø> (-0.05%) ⬇️
cellmerged.go 100% <100%> (+3.92%) ⬆️
cell.go 94.95% <100%> (+2.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c433c5...da0d2ff. Read the comment docs.

@xuri xuri merged commit 3763228 into qax-os:master Dec 15, 2019
@xuri
Copy link
Member

xuri commented Dec 15, 2019

LGTM, thank you.

@xuri xuri added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 21, 2020
nullfy pushed a commit to nullfy/excelize that referenced this pull request Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants