allow to remove MergeCell #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #528 +/- ##
==========================================
- Coverage 96.49% 96.47% -0.02%
==========================================
Files 28 28
Lines 5699 5729 +30
==========================================
+ Hits 5499 5527 +28
- Misses 109 110 +1
- Partials 91 92 +1
Continue to review full report at Codecov.
|
xuri
requested changes
Dec 13, 2019
cellmerged.go
Outdated
| @@ -33,6 +33,24 @@ func (f *File) GetMergeCells(sheet string) ([]MergeCell, error) { | |||
| return mergeCells, err | |||
| } | |||
|
|
|||
| // UnmergeCell unmerge a MergeCell. | |||
| func (f *File) UnmergeCell(sheet string, m MergeCell) error { | |||
There was a problem hiding this comment.
Ok. I didn't find the MergeCell function in cell.go. Maybe the MergeCell will be moved into cellmerged.go in the future or move UnmergeCell to cell.go?
There was a problem hiding this comment.
Yeah right, the MergeCell should be moved into cellmerged.go.
xuri
added
the
size/M
nullfy
pushed a commit
to nullfy/excelize
that referenced
this pull request
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
This PR exposes a method to remove a MergeCell.
Description
I needs to flat all mergecells in excel. I've tried to get the area of a mergecell and use
SetCellValueto set each cell in this area but it didn't work.I think a
RemoveMergeCellis needed.Related Issue
#527
Motivation and Context
How Has This Been Tested
Types of changes
Checklist