Tests refactoring #323
Merged
Tests refactoring #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Primary motivation: Avoid statefull tests with not ignorable git file tree changes. Multiple tests reads and overwrites signle file for won needs. Multiple tests reads and overwrites file under version control. Secondary motivation: Minimal tests logic aligment, separate error expectation and not error expectation tests. Introduce sub-test over test data sets and so far. This commit is not ideal but necessary (IMHO)
Codecov Report
@@ Coverage Diff @@
## master #323 +/- ##
==========================================
- Coverage 98.84% 98.74% -0.11%
==========================================
Files 18 18
Lines 3990 3990
==========================================
- Hits 3944 3940 -4
- Misses 27 31 +4
Partials 19 19
Continue to review full report at Codecov.
|
|
A nice addition. Thank you. |
xuri
added
the
size/XL
nullfy
pushed a commit
to nullfy/excelize
that referenced
this pull request
Oct 23, 2020
Tests refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Tests refactored.
All custom check replaced with
github.com/stretchr/testify/assert.Temporary maped dependency to
github.com/stretchr/testify@masteras of error fixed.Description
This commit is not ideal but necessary (IMHO)
Related Issue
#322
Motivation and Context
Primary motivation: Avoid statefull tests with not ignorable git file tree changes.
Multiple tests reads and overwrites single file for own needs.
Multiple tests reads and overwrites file
Book1.xlsxunder version control.Secondary motivation: Minimal tests logic aligment, separate error expectation
and not error expectation tests. Introduce sub-test over test data sets and so far.
How Has This Been Tested
Simple run
go test ./...and checksgit statusTypes of changes
Checklist