Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #756 remove empty string when set cell value to nil in Stream W… #1481

Conversation

barismar
Copy link
Contributor

@barismar barismar commented Feb 23, 2023

PR Details

Not setting empty string when set cell value to nil in Stream Writer

Description

Not setting cell value to c.setCellValue("") (empty string) when setCellValFunc(c *xlsxC, val interface{}) val param accept nil value

Related Issue

#756

Motivation and Context

Excel that generated with Stream Writer can use excel function like ISBLANK(), COUNTA() etc.

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@barismar barismar marked this pull request as ready for review February 23, 2023 10:39
@xuri xuri added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 23, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2023

Codecov Report

Merging #1481 (64e0f9a) into master (94e86dc) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #1481      +/-   ##
==========================================
- Coverage   98.69%   98.67%   -0.02%     
==========================================
  Files          31       31              
  Lines       24300    24300              
==========================================
- Hits        23982    23979       -3     
- Misses        210      212       +2     
- Partials      108      109       +1     
Flag Coverage Δ
unittests 98.67% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
stream.go 93.63% <100.00%> (ø)
cell.go 98.66% <0.00%> (-0.34%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@xuri xuri merged commit 669c432 into qax-os:master Feb 23, 2023
Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution. This patch will be released in the next version.

xuri pushed a commit to JDavidVR/excelize that referenced this pull request Jul 11, 2023
jenbonzhang pushed a commit to jenbonzhang/excelize that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants