Fix panic in getSheetMap

[liron-l]

Add missing error checks in getSheetMap

PR Details

Missing error checks in getSheetMap

Description

Add error checks for getSheetMap

Related Issue

Motivation and Context

There is no error checks, parser can crash on malformed input

How Has This Been Tested

Tested against a sample corrupted file

Types of changes

• Docs change / refactoring / dependency upgrade
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[codecov-commenter]

Codecov Report

Merging #1437 (d4dfe2f) into master (b39626f) will decrease coverage by 0.01%.
The diff coverage is 76.92%.

@@            Coverage Diff             @@
##           master    #1437      +/-   ##
==========================================
- Coverage   98.57%   98.56%   -0.02%     
==========================================
  Files          31       31              
  Lines       24036    24044       +8     
==========================================
+ Hits        23694    23699       +5     
- Misses        226      228       +2     
- Partials      116      117       +1     

Flag	Coverage Δ
unittests	98.56% <76.92%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
sheet.go	99.72% <70.00%> (-0.28%)	⬇️
excelize.go	99.68% <100.00%> (+<0.01%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[xuri]

Thanks for your pull request. I think the attachment CorruptedRel.xlsx and the test function TestCorruptedRelationship can be removed, the unit tests can be simplified by this patch based on the currently code:

diff --git a/excelize_test.go b/excelize_test.go
index 47d83a8..63d96f4 100644
--- a/excelize_test.go
+++ b/excelize_test.go
@@ -250,7 +250,11 @@ func TestOpenReader(t *testing.T) {
                assert.NoError(t, zw.Close())
                return buf
        }
-       for _, defaultXMLPath := range []string{defaultXMLPathCalcChain, defaultXMLPathStyles} {
+       for _, defaultXMLPath := range []string{
+               defaultXMLPathCalcChain,
+               defaultXMLPathStyles,
+               defaultXMLPathWorkbookRels,
+       } {
                _, err = OpenReader(preset(defaultXMLPath))
                assert.EqualError(t, err, "XML syntax error on line 1: invalid UTF-8")
        }
diff --git a/sheet_test.go b/sheet_test.go
index c44b287..f809fe8 100644
--- a/sheet_test.go
+++ b/sheet_test.go
@@ -114,11 +114,6 @@ func TestSetPanes(t *testing.T) {
        ))
 }
 
-func TestCorruptedRelationship(t *testing.T) {
-       _, err := OpenFile(filepath.Join("test", "CorruptedRel.xlsx"))
-       assert.Error(t, err)
-}
-
 func TestSearchSheet(t *testing.T) {
        f, err := OpenFile(filepath.Join("test", "SharedStrings.xlsx"))
        if !assert.NoError(t, err) {
@@ -383,6 +378,12 @@ func TestGetSheetMap(t *testing.T) {
        }
        assert.Equal(t, len(sheetMap), 2)
        assert.NoError(t, f.Close())
+
+       f = NewFile()
+       f.WorkBook = nil
+       f.Pkg.Store(defaultXMLPathWorkbook, MacintoshCyrillicCharset)
+       _, err = f.getSheetMap()
+       assert.EqualError(t, err, "XML syntax error on line 1: invalid UTF-8")
 }
 
 func TestSetActiveSheet(t *testing.T) {

[xuri]

LGTM, thank you very much.