#1296 add GetRowOpts to Rows

[thomascharbonnel]

Signed-off-by: Thomas Charbonnel [email protected]

PR Details

This PR fixes #1296 and adds a method called GetStyleID on struct Rows{} in order to get access to a row's style ID while stream-reading rows inside an XLSX file.

Description

• Add styleID property to Rows{}
• Set row's style in rows.Next()
• Provide getter rows.GetStyleID
• Create relevant test

Related Issue

#1296

Motivation and Context

This PR adds the ability to read a row's style, which wasn't present before.

How Has This Been Tested

Test fixture file Book1.xlsx was updated to add a row style on the first row of Sheet2. The test makes sure GetStyleID returns the right ID.

Types of changes

• Docs change / refactoring / dependency upgrade
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[codecov-commenter]

Codecov Report

Merging #1297 (156cb4a) into master (b8ceaf7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1297   +/-   ##
=======================================
  Coverage   98.47%   98.47%           
=======================================
  Files          31       31           
  Lines       23448    23482   +34     
=======================================
+ Hits        23090    23124   +34     
  Misses        239      239           
  Partials      119      119           

Flag	Coverage Δ
unittests	98.47% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
rows.go	97.39% <100.00%> (+0.09%)	⬆️
sheet.go	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[thomascharbonnel]

On second thought, it might be better to return a RowOpt struct instead

[xuri]

Thanks for your PR, I've left some comments.

[thomascharbonnel]

I've updated the PR to return RowOpts instead.
I haven't changed styleid to uint because that would mean changing excelize.NewStyle too

[xuri]

Thanks for your update. I've left some comments.

[xuri]

Thanks for your update. In addition, I suggest adding some unit tests.

[xuri]

LGTM, thanks for your great work.