add support for more tabColor options and split RGB #1283

[thomascharbonnel]

This commit renames TabColor into TabColorRGB (but keeps an alias
for backwards compatibility), as well as adds support for more tab color
options (Theme, Indexed and Tint).

Signed-off-by: Thomas Charbonnel [email protected]

Add support for more TabColor options

Description

The following changes were made:

• Rename TabColor into TabColorRGB
• Add TabColorTheme as well as an enum for all its values
• Add TabColorIndexed as well as a default const for when it is unset
• Add TabColorTint as well as a default const for when it is unset

Related Issue

#1283

Motivation and Context

The current version of Excelize only supports TabColor of type "RGB". Excel can set tab colors based on other dimensions (see here).

How Has This Been Tested

By adding tests to the existing tests for worksheet options in sheetpr_test.go
All the tests passed on Linux (Fedora 34, go1.16.13)

Types of changes

• Docs change / refactoring / dependency upgrade
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[xuri]

Thanks for your PR. I've left some comments.

[thomascharbonnel]

Regarding the documentation, i'm not sure if it's updated automatically when i changed the example tests, is that enough?

[xuri]

Regarding the documentation, i'm not sure if it's updated automatically when i changed the example tests, is that enough?

Yes, the example code will be verified by running them as tests.

[codecov-commenter]

Codecov Report

Merging #1285 (2cfc0e0) into master (ebea684) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1285   +/-   ##
=======================================
  Coverage   98.47%   98.47%           
=======================================
  Files          31       31           
  Lines       23417    23450   +33     
=======================================
+ Hits        23059    23092   +33     
  Misses        239      239           
  Partials      119      119           

Flag	Coverage Δ
unittests	98.47% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
sheetpr.go	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

[xuri]

LGTM, thanks for your contribution.

[xuri]

I have added a new exported ColorMappingType used for color transformation, using it instead of integer data type theme color enumeration, and using the ColorMappingType prefix instead of the enumeration with TabColorTheme, because these enumerations not only can be used for the tab theme color, which also can be used for the drawing markup language and themes, so I think we should rename them.

[thomascharbonnel]

Okay looks good 👌 Thomas Charbonnel

…

On Aug 6, 2022, at 3:29 PM, xuri ***@***.***> wrote:  I have added a new exported ColorMappingType used for color transformation, using it instead of integer data type theme color enumeration, and using the ColorMappingType prefix instead of the enumeration with TabColorTheme, because these enumerations not only can be used for the tab theme color, which also can be used for the drawing markup language and themes, so I think we should rename them. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.