Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetRows returns incorrect cell content which uses formula TEXT(C4,"YYYYMMDD") #1665

Closed
fixkme opened this issue Sep 19, 2023 · 5 comments
Closed

GetRows returns incorrect cell content which uses formula TEXT(C4,"YYYYMMDD") #1665

fixkme opened this issue Sep 19, 2023 · 5 comments
Labels
confirmed This issue can be reproduced

Comments

@fixkme
Copy link

fixkme commented Sep 19, 2023

image

image
@xuri
Copy link
Member

xuri commented Sep 19, 2023

Thanks for your issue. Could you follow the issue template, and show us a complete, standalone example program or reproducible demo?

@xuri xuri added the needs more info This issue can't reproduce, need more info label Sep 19, 2023
@fixkme
Copy link
Author

fixkme commented Sep 19, 2023

Thanks for your issue. Could you follow the issue template, and show us a complete, standalone example program or reproducible demo?

image

@xuri
Copy link
Member

xuri commented Sep 19, 2023

Thanks for your feedback. Which version of the Go language and Excelize library are you using? Could you follow the issue template, provide a workbook as attachments without confidential info?

@fixkme
Copy link
Author

fixkme commented Sep 19, 2023

Thanks for your feedback. Which version of the Go language and Excelize library are you using? Could you follow the issue template, provide a workbook as attachments without confidential info?

golang version
go version go1.17.3 windows/amd64

go.mod file

module excel2json

go 1.17

require github.com/xuri/excelize/v2 v2.8.0

require (
	github.com/mohae/deepcopy v0.0.0-20170929034955-c48cc78d4826 // indirect
	github.com/richardlehane/mscfb v1.0.4 // indirect
	github.com/richardlehane/msoleps v1.0.3 // indirect
	github.com/xuri/efp v0.0.0-20230802181842-ad255f2331ca // indirect
	github.com/xuri/nfp v0.0.0-20230819163627-dc951e3ffe1a // indirect
	golang.org/x/crypto v0.12.0 // indirect
	golang.org/x/net v0.14.0 // indirect
	golang.org/x/text v0.12.0 // indirect
)

here is excel file
data.xlsx

@xuri xuri added confirmed This issue can be reproduced in progress Working in progress and removed needs more info This issue can't reproduce, need more info labels Sep 20, 2023
@xuri xuri closed this as completed in 9c079e5 Sep 20, 2023
@xuri
Copy link
Member

xuri commented Sep 20, 2023

Thanks for your issue. I have fixed this issue, please try to upgrade the master branch code, and this patch will be released in the next version.

@xuri xuri removed the in progress Working in progress label Sep 20, 2023
jenbonzhang pushed a commit to jenbonzhang/excelize that referenced this issue Oct 22, 2023
@xuri
This fix qax-os#1665, supports getting formula string cell value
ff7b6a2 
- Improve compatibility for absolute path drawing part
- Fix incorrect table ID generated in the workbook which contains single table cells
- Fix missing relationship parts in the content types in some cases
- Upgrade number format parser to fix missing literal tokens in some cases
- Update built-in zh-cn and zh-tw language number format
- Ref qax-os#65, init new formula function: TEXT
- Remove duplicate style-related variables
- Update the unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed This issue can be reproduced
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xuri @fixkme