Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date: Japanese calendar support #1590

Closed
zztkm opened this issue Jul 27, 2023 · 2 comments
Closed

Date: Japanese calendar support #1590

zztkm opened this issue Jul 27, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@zztkm
Copy link

zztkm commented Jul 27, 2023

Description
I am writing a program to convert an Excel file to csv using Excelize.
Basically, Excelize works well, but it cannot read the date format if the format is a date and Japanese calendar.

I read the source code and found that the Japanese calendar format does not seem to be supported.

I would like to see it supported if possible.

Steps to reproduce the issue:

  1. Excel cell formatting > Date > local: Japanese, Calendar type: Japanese
    • example cell view: 令和3年6月30日 (this is 2021/06/20)
  2. Write the line obtained by excelize.Rows.Columns() to csv

Describe the results you received:
44377

Describe the results you expected:
I wanted to get 令和3年6月30日 as it appeared in Excel

Output of go version:

go version go1.20.6 darwin/arm64

Excelize version or commit ID:

v2.7.1

Environment details (OS, Microsoft Excel™ version, physical, etc.):

  • Windows server 2012 R2
  • Microsoft Excel for Microsoft 365 MSO (version 2301 build: 16.0.16026.20196)
@xuri xuri added enhancement New feature or request in progress Working in progress labels Jul 27, 2023
@xuri xuri closed this as completed in 5fe30eb Jul 30, 2023
@xuri
Copy link
Member

xuri commented Jul 30, 2023

Thanks for your issue. I have added support for the Japanese calendar, please try to upgrade the master branch code, and this feature will be released in the next version.

@xuri xuri removed the in progress Working in progress label Jul 30, 2023
@zztkm
Copy link
Author

zztkm commented Jul 30, 2023

@xuri Thanks for your support!
Looking forward to the next version!

jenbonzhang pushed a commit to jenbonzhang/excelize that referenced this issue Oct 22, 2023
- The `GetFormControl` now support to get text, rich-text and font format of the form controls
- Update the unit tests and the documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants