Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macros rendering as plain text #1461

Closed
af-refined-networks opened this issue Feb 1, 2023 · 4 comments
Closed

Macros rendering as plain text #1461

af-refined-networks opened this issue Feb 1, 2023 · 4 comments
Labels
confirmed This issue can be reproduced

Comments

@af-refined-networks
Copy link

af-refined-networks commented Feb 1, 2023 •
edited
Loading

Description

After reading and writing from and to a xlsm file, the "macro" are being rendered as plain text:

Screenshot 2023-02-01 at 17 57 45

Steps to reproduce the issue:

  1. Open a file via excelize.OpenFile()
  2. Manipulate the opened workbook by either f.SetSheetRow() or f.DeleteSheet()

Describe the results you received:

Both f.SetSheetRow() or f.DeleteSheet() delivers what is expected but the "macros" are being rendered:

Screenshot 2023-02-01 at 17 57 45

Describe the results you expected:

A sheet with the rows 1-8 collpased

Screenshot 2023-02-01 at 18 02 35

Output of go version:

go version go1.19.5 linux/arm64

Excelize version or commit ID:

github.com/xuri/excelize/v2 v2.7.0

Environment details (OS, Microsoft Excel™ version, physical, etc.):

go running in a docker container using official go image alpine. Also tried using the "standard image" to no avail.
@xuri
Copy link
Member

xuri commented Feb 2, 2023

Thanks for your feedback. Could you provide a reproducible demo and your input file attachment without confidential info?

@xuri xuri added the needs more info This issue can't reproduce, need more info label Feb 2, 2023
@af-refined-networks
Copy link
Author

Of course, please find attached.

Archive.zip

@xuri xuri added confirmed This issue can be reproduced in progress Working in progress and removed needs more info This issue can't reproduce, need more info labels Feb 2, 2023
@xuri xuri closed this as completed in be0bd0d Feb 2, 2023
@xuri
Copy link
Member

xuri commented Feb 2, 2023

Thanks for your issue. I have fixed it. Please try to upgrade to the master branch code, and this patch will be released in the next version.

@xuri xuri removed the in progress Working in progress label Feb 2, 2023
xuri added a commit that referenced this issue Feb 2, 2023
@xuri
This fixes #1461, supports 0 row height and column width
12645e7 
- Increase max cell styles to 65430
- Add new exported error variable `ErrCellStyles`
- Update unit tests, support test under Go 1.20.x
@af-refined-networks
Copy link
Author

Hi, I can confirm that the issue has been fixed. Thank you very much for your speedy response. Much appreciated.

xuri added a commit to JDavidVR/excelize that referenced this issue Jul 11, 2023
@xuri
This fixes qax-os#1461, supports 0 row height and column width
a0636ea 
- Increase max cell styles to 65430
- Add new exported error variable `ErrCellStyles`
- Update unit tests, support test under Go 1.20.x
jenbonzhang pushed a commit to jenbonzhang/excelize that referenced this issue Oct 22, 2023
@xuri
This fixes qax-os#1461, supports 0 row height and column width
4706318 
- Increase max cell styles to 65430
- Add new exported error variable `ErrCellStyles`
- Update unit tests, support test under Go 1.20.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed This issue can be reproduced
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xuri @af-refined-networks